This is an evolving post to show the unit tests fixing progression.

red = errors, orange = failures, green = pass

1. At the beginning, the errors are high because of the calls to the legacy ‘v_title’ and content methods which do not exist anymore (replaced by property).
2. Fixed Version tests.
3. Fixed Template tests.
4. Renamed Node.name to Node.node_name to avoid confusion with Contact.name or other uses. (Error peak)
5. Fixed (and refactoring) of Document and Attachment tests.
6. Started fixing helpers testing (had to rewrite controller mockup and such), did some review of the ‘node_name’ change consequences.
7. Fixing Node tests (not all done) and fixed Workflow tests.
8. Implemented Roles and Enrollable (dynamic role activation on write)
9. Making Secure, VersionHash and Workflow tests pass.
10. Fixed Relations, QueryNode, Image and Co
11. Fixed typos in tests, all pass except 1 test (passes alone, but not with others): locale issue
12. Fixed last test (“strftime” was depending on ENV['LANG'] ).

All the unit tests pass now !

conclusion

8%

This is the test count growth, mostly due to the refactoring of large tests into smaller tests by using shoulda.

a graph is good

Having a graph with real numbers was very helpful to see that work was advancing even though I felt things were going worse (see bump in the graph).

1989 tests, 3909 assertions, 388 failures, 77 errors

This is the current number of passing/failing tests in Zena’s full test suite and gives an idea of the work left.

Integration (aka Zafu) bug fixing tests can be followed in this post.